Skip to content

Match pod status with resource status #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2019
Merged

Match pod status with resource status #38

merged 4 commits into from
Mar 21, 2019

Conversation

@1vn
Copy link
Contributor

@1vn 1vn commented Mar 21, 2019 •
edited
Loading

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart local operator, and run cx refresh in an example folder)
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

deliahu
deliahu approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deliahu
deliahu approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1vn 1vn merged commit 186d8a3 into master Mar 21, 2019
@1vn 1vn deleted the fix-error-status branch March 21, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@1vn @deliahu